refactor: cleanup test for api-client #4420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomrc
force-pushed
the
refactor/cleanup-api-client
branch
from
4c59006 to
2f9c86d
Compare
tlebon
reviewed
Oct 4, 2022
Comment on lines
+284
to
+287
| jest.spyOn(client.api.auth, 'postLogout').mockReturnValue(Promise.reject(testError)); | ||
| jest.spyOn(client, 'disconnect').mockReturnValue(); | ||
| jest.spyOn(client['accessTokenStore'], 'delete').mockReturnValue(Promise.resolve(undefined)); | ||
| jest.spyOn(client['logger'], 'warn').mockReturnValue(); |
There was a problem hiding this comment.
maybe makes sense to destructure spyOn from jest just to have a few less characters?
There was a problem hiding this comment.
If you don't have strong opinion on this, I'd like to keep it this way. I don't think character count is a very useful metrics
tlebon
reviewed
Oct 4, 2022
Comment on lines
+296
to
+299
| jest.spyOn(client.api.auth, 'postLogout'); | ||
| jest.spyOn(client, 'disconnect').mockReturnValue(); | ||
| jest.spyOn(client['accessTokenStore'], 'delete').mockReturnValue(Promise.resolve(undefined)); | ||
| jest.spyOn(client['logger'], 'warn').mockReturnValue(); |
There was a problem hiding this comment.
thisisamir98
approved these changes
Oct 4, 2022
tlebon
reviewed
Oct 4, 2022
| const websocketClient = new WebSocketClient('url', fakeHttpClient); | ||
| const onOpenSpy = spyOn<any>(websocketClient, 'onOpen').and.callThrough(); | ||
| const websocketClient = new WebSocketClient('ws://url', fakeHttpClient); | ||
| const onOpenSpy = jest.spyOn(websocketClient as any, 'onOpen'); |
There was a problem hiding this comment.
maybe destructuring makes sense in this file also since its called many times. also wondering about all these as any blocks if they can be improved
There was a problem hiding this comment.
they sadly cannot be improved easily since the test is relying on mocking private methods :/
This would be too much of a hustle trying to fix this, so I'm restoring to the original behavior
tlebon
reviewed
Oct 4, 2022
packages/api-client/src/conversation/ConversationAPI/ConversationAPI.test.ts
Outdated
Show resolved
Hide resolved
…ionAPI.test.ts Co-authored-by: Timothy LeBon <[email protected]>
tlebon
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the dependencies to webpack/karma related process that are slowing down quite a lot.
We need generate a pristine tsc compiled library that doesn't require building for a browser.